WIP: --sfx-volume option #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanodan
force-pushed
the
feature/23-effect-volume
branch
from
247d107
to
24b105f
Compare
fmang
reviewed
Sep 22, 2018
| @@ -72,6 +72,7 @@ class base : public mode { | |||
| struct oshu_sound_library library {}; | |||
| struct oshu_clock clock {}; | |||
| int autoplay {}; | |||
| int sfx_volume {}; | |||
There was a problem hiding this comment.
Use a [0, 1] float here, and set its default value to 1.
fmang
reviewed
Sep 22, 2018
| .TP | ||
| \fB\-\-sfx\-volume\fR | ||
| Sets the volume of the effects (i.e hitsounds), minimum(~mute) is 0, maximum | ||
| is 100 |
There was a problem hiding this comment.
It's a bit more work, but I think --sfx-volume 50% is much clearer with the explicit %.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #23